]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: mpi3mr: Validate SAS port assignments
authorRanjan Kumar <ranjan.kumar@broadcom.com>
Tue, 8 Oct 2024 07:43:53 +0000 (13:13 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 16 Oct 2024 02:17:17 +0000 (22:17 -0400)
commitb9e63d6c7c0e94a99e1af7c9c0c7fad13a2f2453
treed9e73636a0793543c8ab31b0fe90a549a6a62b6a
parent19a198b67767d952c8f3d0cf24eb3100522a8223
scsi: mpi3mr: Validate SAS port assignments

A sanity check on phy_mask was added in commit 3668651def2c ("scsi:
mpi3mr: Sanitise num_phys"). This causes warning messages when more than
64 phys are detected and devices connected to phys greater than 64 are
dropped.

The phy_mask bitmap is only needed for controller phys and not required
for expander phys. Controller phys can go up to a maximum of 64 and
therefore u64 is good enough to contain phy_mask bitmap.

To suppress those warnings and allow devices to be discovered as before
the offending commit, restrict the phy_mask setting and lowest phy
setting only to the controller phys.

Fixes: 3668651def2c ("scsi: mpi3mr: Sanitise num_phys")
Cc: stable@vger.kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202410051943.Mp9o5DlF-lkp@intel.com/
Reported-by: Alexander Motin <mav@ixsystems.com>
Signed-off-by: Ranjan Kumar <ranjan.kumar@broadcom.com>
Link: https://lore.kernel.org/r/20241008074353.200379-1-ranjan.kumar@broadcom.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpi3mr/mpi3mr.h
drivers/scsi/mpi3mr/mpi3mr_transport.c