]> www.infradead.org Git - users/dwmw2/linux.git/commit
ASoC: rt5682: fix I2C/Soundwire dependencies
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Apr 2020 21:46:14 +0000 (23:46 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:48:38 +0000 (17:48 +0200)
commitb9b43a3a24868dfdea86a963c196920c53f9364c
treee68a7b1c71f39059a7e06655b24a806454e570fd
parent0154d54061efd14093649147b8d941f7d83d6957
ASoC: rt5682: fix I2C/Soundwire dependencies

[ Upstream commit fd443a20c2f0950f3c31765a08f7dd49b3bc69cb ]

If one of the two is a loadable module, the combined driver must
not be built-in:

aarch64-linux-ld: sound/soc/codecs/rt5682.o: in function `rt5682_sdw_hw_free':
rt5682.c:(.text+0xb34): undefined reference to `sdw_stream_remove_slave'
aarch64-linux-ld: sound/soc/codecs/rt5682.o: in function `rt5682_sdw_hw_params':
rt5682.c:(.text+0xe78): undefined reference to `sdw_stream_add_slave'

In particular, the soundwire driver must not be built-in if
CONFIG_I2C=m.

Fixes: 5549ea647997 ("ASoC: rt5682: fix unmet dependencies")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20200428214642.3925004-1-arnd@arndb.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/codecs/Kconfig