]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xen-blkfront: don't call talk_to_blkback when already connected to blkback
authorBob Liu <bob.liu@oracle.com>
Tue, 7 Jun 2016 14:43:15 +0000 (10:43 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Tue, 28 Jun 2016 14:50:23 +0000 (07:50 -0700)
commitb972d5fe032b96138796903aa35aed9d495b9b4f
tree40444f549bca7738c3a7b98f7d1d1b8dc82eaffb
parent4014e44c727e539e342882aded6be2aec7e811d0
xen-blkfront: don't call talk_to_blkback when already connected to blkback

Sometimes blkfront may twice receive blkback_changed() notification
(XenbusStateConnected) after migration, which will cause
talk_to_blkback() to be called twice too and confuse xen-blkback.

The flow is as follow:
   blkfront                                        blkback
blkfront_resume()
 > talk_to_blkback()
  > Set blkfront to XenbusStateInitialised
                                                front changed()
                                                 > Connect()
                                                  > Set blkback to XenbusStateConnected

blkback_changed()
 > Skip talk_to_blkback()
   because frontstate == XenbusStateInitialised
 > blkfront_connect()
  > Set blkfront to XenbusStateConnected

-----
And here we get another XenbusStateConnected notification leading
to:
-----
blkback_changed()
 > because now frontstate != XenbusStateInitialised
   talk_to_blkback() is also called again
  > blkfront state changed from
  XenbusStateConnected to XenbusStateInitialised
    (Which is not correct!)

front_changed():
                                                 > Do nothing because blkback
                                                   already in XenbusStateConnected

Now blkback is in XenbusStateConnected but blkfront is still
in XenbusStateInitialised - leading to no disks.

Poking of the XenbusStateConnected state is allowed (to deal with
block disk change) and has to be dealt with. The most likely
cause of this bug are custom udev scripts hooking up the disks
and then validating the size.

Signed-off-by: Bob Liu <bob.liu@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Orabug: 23340426
(cherry picked from commit efd1535270c1deb0487527bf0c3c827301a69c93)
Signed-off-by: Bob Liu <bob.liu@oracle.com>
drivers/block/xen-blkfront.c