]> www.infradead.org Git - users/willy/pagecache.git/commit
ice: Fix entering Safe Mode
authorMarcin Szycik <marcin.szycik@linux.intel.com>
Tue, 24 Sep 2024 10:04:23 +0000 (12:04 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 8 Oct 2024 21:08:19 +0000 (14:08 -0700)
commitb972060a47780aa2d46441e06b354156455cc877
tree6dbb39fe7fbe55d339af0b91a4cc2cbe44af6ab9
parent1fd9e4f257827d939cc627541f12fc4bdd979eb1
ice: Fix entering Safe Mode

If DDP package is missing or corrupted, the driver should enter Safe Mode.
Instead, an error is returned and probe fails.

To fix this, don't exit init if ice_init_ddp_config() returns an error.

Repro:
* Remove or rename DDP package (/lib/firmware/intel/ice/ddp/ice.pkg)
* Load ice

Fixes: cc5776fe1832 ("ice: Enable switching default Tx scheduler topology")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c