]> www.infradead.org Git - users/jedix/linux-maple.git/commit
staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT
authorKautuk Consul <consul.kautuk@gmail.com>
Wed, 14 Sep 2011 03:26:21 +0000 (08:56 +0530)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Thu, 8 Dec 2011 19:17:42 +0000 (11:17 -0800)
commitb946b8d447cc104224938f12bf3befdb7766846b
tree2a00cdbb18072ef009d59d600a846ed018183b1a
parent8d727adb64a62e25cd1ec15be5920c180c7efdae
staging: quatech_usb2: Potential lost wakeup scenario in TIOCMIWAIT

commit e8df1674d383d2ecc6efa8d7dba74c03aafdfdd7 upstream.

If the usermode app does an ioctl over this serial device  by
using TIOCMIWAIT, then the code will wait by setting the current
task state to TASK_INTERRUPTIBLE and then calling schedule().
This will be woken up by the qt2_process_modem_status on URB
completion when the port_extra->shadowMSR is set to the new
modem status.

However, this could result in a lost wakeup scenario due to a race
in the logic in the qt2_ioctl(TIOCMIWAIT) loop and the URB completion
for new modem status in qt2_process_modem_status.
Due to this, the usermode app's task will continue to sleep despite a
change in the modem status.

Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/quatech_usb2/quatech_usb2.c