]> www.infradead.org Git - users/willy/pagecache.git/commit
nfsd: validate the nfsd_serv pointer before calling svc_wake_up
authorJeff Layton <jlayton@kernel.org>
Sun, 26 Jan 2025 01:13:18 +0000 (20:13 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 2 Feb 2025 16:31:58 +0000 (11:31 -0500)
commitb9382e29ca538b879645899ce45d652a304e2ed2
tree3aabf6706ea6d5273e62d779444ad4c89a113934
parent7faf14a7b0366f153284db0ad3347c457ea70136
nfsd: validate the nfsd_serv pointer before calling svc_wake_up

nfsd_file_dispose_list_delayed can be called from the filecache
laundrette, which is shut down after the nfsd threads are shut down and
the nfsd_serv pointer is cleared. If nn->nfsd_serv is NULL then there
are no threads to wake.

Ensure that the nn->nfsd_serv pointer is non-NULL before calling
svc_wake_up in nfsd_file_dispose_list_delayed. This is safe since the
svc_serv is not freed until after the filecache laundrette is cancelled.

Reported-by: Salvatore Bonaccorso <carnil@debian.org>
Closes: https://bugs.debian.org/1093734
Fixes: ffb402596147 ("nfsd: Don't leave work of closing files to a work queue")
Cc: stable@vger.kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c