]> www.infradead.org Git - users/dwmw2/linux.git/commit
hwmon: (acpi_power_meter) Change log level for 'unsafe software power cap'
authorWang Shenran <shenran268@gmail.com>
Wed, 24 Jul 2019 08:01:10 +0000 (11:01 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 11:13:53 +0000 (13:13 +0200)
commitb92d8e39fa7060302ad1c0e7227f0ecb2af0cb2d
tree14bfb30fab726c6cff5b42fa7043c44b31c063a9
parentd57d9213d8b81923db5b0b3b12a1e52f44d22b01
hwmon: (acpi_power_meter) Change log level for 'unsafe software power cap'

[ Upstream commit 6e4d91aa071810deac2cd052161aefb376ecf04e ]

At boot time, the acpi_power_meter driver logs the following error level
message: "Ignoring unsafe software power cap". Having read about it from
a few sources, it seems that the error message can be quite misleading.

While the message can imply that Linux is ignoring the fact that the
system is operating in potentially dangerous conditions, the truth is
the driver found an ACPI_PMC object that supports software power
capping. The driver simply decides not to use it, perhaps because it
doesn't support the object.

The best solution is probably changing the log level from error to warning.
All sources I have found, regarding the error, have downplayed its
significance. There is not much of a reason for it to be on error level,
while causing potential confusions or misinterpretations.

Signed-off-by: Wang Shenran <shenran268@gmail.com>
Link: https://lore.kernel.org/r/20190724080110.6952-1-shenran268@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/acpi_power_meter.c