]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fbdev: tgafb: Fix potential divide by zero
authorWei Chen <harperchen1110@gmail.com>
Tue, 7 Mar 2023 13:08:56 +0000 (13:08 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Apr 2023 10:10:40 +0000 (12:10 +0200)
commitb8b7d5eac5ee984e42424de776ec1e04d1cc2f89
treebecbf4361ba6faa4fc62fc63dc67a9fca462a12a
parent32854bc91ae7debcdefdc7ae881ed83385a04792
fbdev: tgafb: Fix potential divide by zero

[ Upstream commit f90bd245de82c095187d8c2cabb8b488a39eaecc ]

fb_set_var would by called when user invokes ioctl with cmd
FBIOPUT_VSCREENINFO. User-provided data would finally reach
tgafb_check_var. In case var->pixclock is assigned to zero,
divide by zero would occur when checking whether reciprocal
of var->pixclock is too high.

Similar crashes have happened in other fbdev drivers. There
is no check and modification on var->pixclock along the call
chain to tgafb_check_var. We believe it could also be triggered
in driver tgafb from user site.

Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/video/fbdev/tgafb.c