]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ixgbe: call ndo_stop() instead of dev_close() when running offline selftest
authorStefan Assmann <sassmann@kpanic.de>
Wed, 3 Feb 2016 08:20:48 +0000 (09:20 +0100)
committerChuck Anderson <chuck.anderson@oracle.com>
Wed, 6 Jul 2016 23:40:57 +0000 (16:40 -0700)
commitb8b0a69ed1534487a9aa9352a776046038b953fe
treee7df6ea65e86d3a5d4b37c5218f19088dda79d85
parent7768397b899099c372af7ea1e3d856df9f588396
ixgbe: call ndo_stop() instead of dev_close() when running offline selftest

Orabug: 23177316

Calling dev_close() causes IFF_UP to be cleared which will remove the
interfaces routes and some addresses. That's probably not what the user
intended when running the offline selftest. Besides this does not happen
if the interface is brought down before the test, so the current
behaviour is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.

Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit 6c211fe1e71e2bf7baa45a78ac5358a1f45a7fe9)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/intel/ixgbe/ixgbe.h
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c