]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sched/core: Tweak wait_task_inactive() to force dequeue sched_delayed tasks
authorJohn Stultz <jstultz@google.com>
Tue, 29 Apr 2025 15:07:26 +0000 (08:07 -0700)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 30 Apr 2025 12:45:41 +0000 (14:45 +0200)
commitb7ca5743a2604156d6083b88cefacef983f3a3a6
tree6161a960a530de7ba3db9fde196f9377ebaa224a
parentc70fc32f44431bb30f9025ce753ba8be25acbba3
sched/core: Tweak wait_task_inactive() to force dequeue sched_delayed tasks

It was reported that in 6.12, smpboot_create_threads() was
taking much longer then in 6.6.

I narrowed down the call path to:
 smpboot_create_threads()
 -> kthread_create_on_cpu()
    -> kthread_bind()
       -> __kthread_bind_mask()
          ->wait_task_inactive()

Where in wait_task_inactive() we were regularly hitting the
queued case, which sets a 1 tick timeout, which when called
multiple times in a row, accumulates quickly into a long
delay.

I noticed disabling the DELAY_DEQUEUE sched feature recovered
the performance, and it seems the newly create tasks are usually
sched_delayed and left on the runqueue.

So in wait_task_inactive() when we see the task
p->se.sched_delayed, manually dequeue the sched_delayed task
with DEQUEUE_DELAYED, so we don't have to constantly wait a
tick.

Fixes: 152e11f6df29 ("sched/fair: Implement delayed dequeue")
Reported-by: peter-yc.chang@mediatek.com
Signed-off-by: John Stultz <jstultz@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: K Prateek Nayak <kprateek.nayak@amd.com>
Link: https://lkml.kernel.org/r/20250429150736.3778580-1-jstultz@google.com
kernel/sched/core.c