]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dm-table: Set BLK_FEAT_ATOMIC_WRITES for target queue limits
authorJohn Garry <john.g.garry@oracle.com>
Sun, 4 May 2025 09:26:45 +0000 (11:26 +0200)
committerMikulas Patocka <mpatocka@redhat.com>
Sun, 4 May 2025 10:02:39 +0000 (12:02 +0200)
commitb7c18b17a173087ce97e809cefd55e581121f19e
treea4ebc65bec2eee4e13f8ad880774ef48aefba8c1
parent7734fb4ad98c3fdaf0fde82978ef8638195a5285
dm-table: Set BLK_FEAT_ATOMIC_WRITES for target queue limits

Feature flag BLK_FEAT_ATOMIC_WRITES is not being properly set for the
target queue limits, and this means that atomic writes are not being
enabled for any dm personalities.

When calling dm_set_device_limits() -> blk_stack_limits() ->
... -> blk_stack_atomic_writes_limits(), the bottom device limits
(which corresponds to intermediate target queue limits) does not have
BLK_FEAT_ATOMIC_WRITES set, and so atomic writes can never be enabled.

Typically such a flag would be inherited from the stacked device in
dm_set_device_limits() -> blk_stack_limits() via BLK_FEAT_INHERIT_MASK,
but BLK_FEAT_ATOMIC_WRITES is not inherited as it's preferred to manually
enable on a per-personality basis.

Set BLK_FEAT_ATOMIC_WRITES manually for the intermediate target queue
limits from the stacked device to get atomic writes working.

Fixes: 3194e36488e2 ("dm-table: atomic writes support")
Cc: stable@vger.kernel.org # v6.14
Signed-off-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-table.c