]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf stat: Stop repeating when ref_perf_stat() returns -1
authorLevi Yun <yeoreum.yun@arm.com>
Wed, 25 Sep 2024 13:20:22 +0000 (14:20 +0100)
committerNamhyung Kim <namhyung@kernel.org>
Wed, 25 Sep 2024 22:58:42 +0000 (15:58 -0700)
commitb77f8c36ce0b23da97f5442c2f55cc98c2cb5567
treece270d821fa91d4efbc55f76ab7b183fac030d0e
parente880a70f8046df0dd9089fa60dcb866a2cc69194
perf stat: Stop repeating when ref_perf_stat() returns -1

Exit when run_perf_stat() returns an error to avoid continuously
repeating the same error message. It's not expected that COUNTER_FATAL
or internal errors are recoverable so there's no point in retrying.

This fixes the following flood of error messages for permission issues,
for example when perf_event_paranoid==3:
  perf stat -r 1044 -- false

  Error:
  Access to performance monitoring and observability operations is limited.
  ...
  Error:
  Access to performance monitoring and observability operations is limited.
  ...
  (repeating for 1044 times).

Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Cc: nd@arm.com
Cc: howardchu95@gmail.com
Link: https://lore.kernel.org/r/20240925132022.2650180-3-yeoreum.yun@arm.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/builtin-stat.c