]> www.infradead.org Git - users/dwmw2/linux.git/commit
ARM: imx: Re-introduce the PINCTRL selection
authorFabio Estevam <festevam@denx.de>
Wed, 27 Nov 2024 19:06:05 +0000 (16:06 -0300)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 3 Dec 2024 09:58:42 +0000 (10:58 +0100)
commitb77bd3ba762f34e5eb731134cf50e233d1060053
treec3a3a748a4fe32360412caca5d10d7f6eae74e33
parent40384c840ea1944d7c5a392e8975ed088ecf0b37
ARM: imx: Re-introduce the PINCTRL selection

Since commit 17d210018914 ("ARM: imx: Allow user to disable pinctrl"),
the CONFIG_PINCTRL option is no longer implicitly selected, causing
several i.MX SoC pinctrl drivers no longer getting selected by default.

This causes boot regressions on the ARMv4, ARMv5, ARMv6 and ARMv7
i.MX SoCs.

Fix it by selecting CONFIG_PINCTRL as before.

This defeats the purpose of 7d210018914 ("ARM: imx: Allow user to disable
pinctrl"), but it is the less invasive fix for the boot regressions.

The attempt to build Layerscape without pinctrl can still be explored
later as suggested by Arnd:

"Overall, my best advice here is still to not change the way
i.MX pinctrl works at all, but just fix Layerscape to not depend
on i.MX. The reason for the 'select' here is clearly that the
i.MX machines would fail to boot without pinctrl, and changing
that because of Layerscape seems backwards."

Fixes: 17d210018914 ("ARM: imx: Allow user to disable pinctrl")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Closes: https://lore.kernel.org/linux-arm-kernel/49ff070a-ce67-42d7-84ec-8b54fd7e9742@roeck-us.net/
Signed-off-by: Fabio Estevam <festevam@denx.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/20241127190605.1367157-1-festevam@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
arch/arm/mach-imx/Kconfig