]> www.infradead.org Git - users/jedix/linux-maple.git/commit
can bcm: fix tx_setup off-by-one errors
authorOliver Hartkopp <socketcan@hartkopp.net>
Fri, 23 Sep 2011 08:23:47 +0000 (08:23 +0000)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Thu, 8 Dec 2011 19:18:01 +0000 (11:18 -0800)
commitb70eb6309f53f2362951502f74b5c1782a4a3d5f
treea206801af1510026b9ddf82ed3166eb0a23fdcc1
parent250b17b19ed6544a3af7184210cc39830134beca
can bcm: fix tx_setup off-by-one errors

[ Upstream commit aabdcb0b553b9c9547b1a506b34d55a764745870 ]

This patch fixes two off-by-one errors that canceled each other out.
Checking for the same condition two times in bcm_tx_timeout_tsklet() reduced
the count of frames to be sent by one. This did not show up the first time
tx_setup is invoked as an additional frame is sent due to TX_ANNONCE.
Invoking a second tx_setup on the same item led to a reduced (by 1) number of
sent frames.

Reported-by: Andre Naujoks <nautsch@gmail.com>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/can/bcm.c