]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: mscc: ocelot: improve handling of TX timestamp for unknown skb
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 5 Dec 2024 14:55:16 +0000 (16:55 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sun, 8 Dec 2024 01:56:46 +0000 (17:56 -0800)
commitb6fba4b3f0becb794e274430f3a0839d8ba31262
treead8d27c68ee15307ed0aec8a3aa1dab4dec59218
parent4b01bec25bef62544228bce06db6a3afa5d3d6bb
net: mscc: ocelot: improve handling of TX timestamp for unknown skb

This condition, theoretically impossible to trigger, is not really
handled well. By "continuing", we are skipping the write to SYS_PTP_NXT
which advances the timestamp FIFO to the next entry. So we are reading
the same FIFO entry all over again, printing stack traces and eventually
killing the kernel.

No real problem has been observed here. This is part of a larger rework
of the timestamp IRQ procedure, with this logical change split out into
a patch of its own. We will need to "goto next_ts" for other conditions
as well.

Fixes: 9fde506e0c53 ("net: mscc: ocelot: warn when a PTP IRQ is raised for an unknown skb")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20241205145519.1236778-3-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mscc/ocelot_ptp.c