]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf x86/topdown: Make topdown metrics comparators be symmetric
authorDapeng Mi <dapeng1.mi@linux.intel.com>
Fri, 11 Oct 2024 11:02:06 +0000 (11:02 +0000)
committerNamhyung Kim <namhyung@kernel.org>
Wed, 16 Oct 2024 20:36:41 +0000 (13:36 -0700)
commitb68b5b36c790a82522623f9f1fd1c4e1f06aff2d
tree4ab89b810c9b78cd8ceb70605ce184c7551719f7
parent42fd7cac57d6001974a0546e5eb50a430aa95b11
perf x86/topdown: Make topdown metrics comparators be symmetric

The commit "3b5edc0421e2 (perf x86/topdown: Don't move topdown metric
 events in group)" modifies topdown metrics comparator to move topdown
metrics events which are not in same group with previous event. But it
just modifies the 2nd comparator and causes the comparators become
asymmetric.

Thus modify the 1st topdown metrics comparator and make the two
comparators be symmetric, and refine the comments as well.

Suggested-by: Ian Rogers <irogers@google.com>
Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20241011110207.1032235-1-dapeng1.mi@linux.intel.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/arch/x86/util/evlist.c