]> www.infradead.org Git - users/dwmw2/openconnect.git/commit
fix <select>/<option> parsing bug
authorDaniel Lenski <dlenski@gmail.com>
Tue, 23 Feb 2021 04:46:15 +0000 (20:46 -0800)
committerDaniel Lenski <dlenski@gmail.com>
Mon, 29 Mar 2021 02:27:01 +0000 (19:27 -0700)
commitb67465a9f05b5a078f1d29d57896b13888d18d19
treea330b0dd3fff3bc3418336c980d25a8101cddd17
parente6ce815e112415e8a00cf838bcaf9121be3503de
fix <select>/<option> parsing bug

The Juniper form-handling code was setting <select>/<option> labels
identically to their values.

Presumably, this was never caught before because they never actually differ
in real Juniper login forms? (but they do in F5 forms)

That is, a Juniper <option> field always looks like…

    <select name="realm">
      <option value="Something">Something</option>
      <option value="Another">Another</option>
    </select>

… and never like this:

    <select name="realm">
      <option value="group1">Something</option>
      <option value="group2">Another</option>
    </select>

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
auth-html.c