]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cifs: don't cargo-cult strndup()
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 5 Mar 2021 20:02:34 +0000 (15:02 -0500)
committerSteve French <stfrench@microsoft.com>
Tue, 13 Apr 2021 04:52:24 +0000 (23:52 -0500)
commitb65ebf0a44f5c0184386d0a58a1b2b0e6b4850f2
tree49a735f949595872f8d839fbe2988b5cca524221
parent010709348678231f4b8cf74c832d1e294f6436d9
cifs: don't cargo-cult strndup()

strndup(s, strlen(s)) is a highly unidiomatic way to spell strdup(s);
it's *NOT* safer in any way, since strlen() is just as sensitive to
NUL-termination as strdup() is.

strndup() is for situations when you need a copy of a known-sized
substring, not a magic security juju to drive the bad spirits away.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/cifs_dfs_ref.c
fs/cifs/connect.c
fs/cifs/dfs_cache.c
fs/cifs/fs_context.c
fs/cifs/misc.c
fs/cifs/smb1ops.c
fs/cifs/unc.c