]> www.infradead.org Git - users/dwmw2/linux.git/commit
bcache: only clear BTREE_NODE_dirty bit when it is set
authorColy Li <colyli@suse.de>
Fri, 28 Jun 2019 11:59:55 +0000 (19:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 16 Sep 2019 06:23:20 +0000 (08:23 +0200)
commitb622ba2bcd4edf70a307db16e94f2292563bdc8d
tree7cf2186f9dd0680f262df5927e243bfb5c4c4d63
parentbb70b2729b7a425f840e01c64348ed5c63699de2
bcache: only clear BTREE_NODE_dirty bit when it is set

In bch_btree_cache_free() and btree_node_free(), BTREE_NODE_dirty is
always set no matter btree node is dirty or not. The code looks like
this,
if (btree_node_dirty(b))
btree_complete_write(b, btree_current_write(b));
clear_bit(BTREE_NODE_dirty, &b->flags);

Indeed if btree_node_dirty(b) returns false, it means BTREE_NODE_dirty
bit is cleared, then it is unnecessary to clear the bit again.

This patch only clears BTREE_NODE_dirty when btree_node_dirty(b) is
true (the bit is set), to save a few CPU cycles.

Signed-off-by: Coly Li <colyli@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/btree.c