]> www.infradead.org Git - users/hch/misc.git/commit
netdev: clarify GSO vs csum in qstats
authorJakub Kicinski <kuba@kernel.org>
Fri, 14 Feb 2025 22:46:01 +0000 (14:46 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 18 Feb 2025 00:48:32 +0000 (16:48 -0800)
commitb5e489003abcff4b65088d49fce78dcb3cc1ae06
tree91aeac3697451aaf9906dac96fe08d62cfb886a1
parent637026e591fae3b91986c01e3beab9bb664bda2d
netdev: clarify GSO vs csum in qstats

Could be just me, but I had to pause and double check that the Tx csum
counter in qstat should include GSO'd packets. GSO pretty much implies
csum so one could possibly interpret the csum counter as pure csum offload.

But the counters are based on virtio:

  [tx_needs_csum]
      The number of packets which require checksum calculation by the device.

  [rx_needs_csum]
      The number of packets with VIRTIO_NET_HDR_F_NEEDS_CSUM.

and VIRTIO_NET_HDR_F_NEEDS_CSUM gets set on GSO packets virtio sends.

Clarify this in the spec to avoid any confusion.

Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20250214224601.2271201-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Documentation/netlink/specs/netdev.yaml