]> www.infradead.org Git - users/dwmw2/linux.git/commit
wifi: cfg80211: clear link ID from bitmap during link delete after clean up
authorAditya Kumar Singh <quic_adisi@quicinc.com>
Thu, 21 Nov 2024 04:15:30 +0000 (09:45 +0530)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 3 Dec 2024 10:28:20 +0000 (11:28 +0100)
commitb5c32ff6a3a38c74facdd1fe34c0d709a55527fd
tree7c4980c503dc2ffaecb667edd8a8c805de7c1068
parent496db69fd860570145f7c266b31f3af85fca5b00
wifi: cfg80211: clear link ID from bitmap during link delete after clean up

Currently, during link deletion, the link ID is first removed from the
valid_links bitmap before performing any clean-up operations. However, some
functions require the link ID to remain in the valid_links bitmap. One
such example is cfg80211_cac_event(). The flow is -

nl80211_remove_link()
    cfg80211_remove_link()
        ieee80211_del_intf_link()
            ieee80211_vif_set_links()
                ieee80211_vif_update_links()
                    ieee80211_link_stop()
                        cfg80211_cac_event()

cfg80211_cac_event() requires link ID to be present but it is cleared
already in cfg80211_remove_link(). Ultimately, WARN_ON() is hit.

Therefore, clear the link ID from the bitmap only after completing the link
clean-up.

Signed-off-by: Aditya Kumar Singh <quic_adisi@quicinc.com>
Link: https://patch.msgid.link/20241121-mlo_dfs_fix-v2-1-92c3bf7ab551@quicinc.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/cfg.c
net/wireless/util.c