]> www.infradead.org Git - users/jedix/linux-maple.git/commit
f2fs: avoid attaching SB_ACTIVE flag during mount/remount
authorChao Yu <yuchao0@huawei.com>
Tue, 25 May 2021 11:39:09 +0000 (19:39 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Wed, 26 May 2021 14:00:36 +0000 (07:00 -0700)
commitb585a90e9fe22457fe93b2314c18cbf8aa93d8eb
tree6e8e6608a852c6b91a26dda19b88d1ee0b0d3575
parent8939a8489ca64b56f49428b0d882709080a928d4
f2fs: avoid attaching SB_ACTIVE flag during mount/remount

Quoted from [1]

"I do remember that I've added this code back then because otherwise
orphan cleanup was losing updates to quota files. But you're right
that now I don't see how that could be happening and it would be nice
if we could get rid of this hack"

[1] https://lore.kernel.org/linux-ext4/99cce8ca-e4a0-7301-840f-2ace67c551f3@huawei.com/T/#m04990cfbc4f44592421736b504afcc346b2a7c00

Related fix in ext4 by
commit 72ffb49a7b62 ("ext4: do not set SB_ACTIVE in ext4_orphan_cleanup()").

f2fs has the same hack implementation in
- f2fs_recover_orphan_inodes()
- f2fs_recover_fsync_data()
- f2fs_disable_checkpoint()

Let's get rid of this hack as well in f2fs.

Cc: Zhang Yi <yi.zhang@huawei.com>
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Acked-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/checkpoint.c
fs/f2fs/recovery.c
fs/f2fs/super.c