]> www.infradead.org Git - users/jedix/linux-maple.git/commit
workqueue: Avoid nr_active manipulation in grabbing inactive items
authorLai Jiangshan <jiangshan.ljs@antgroup.com>
Wed, 19 Jun 2024 10:39:34 +0000 (18:39 +0800)
committerTejun Heo <tj@kernel.org>
Wed, 19 Jun 2024 17:40:15 +0000 (07:40 -1000)
commitb56c720718e97d2a1a0523e38fdc836adc188a2e
tree784193acd3e3ecd6190ae5b9443e39298b4444d0
parent37c2277fad7e90e2ca1202c9cdd13329ac91ecff
workqueue: Avoid nr_active manipulation in grabbing inactive items

Current try_to_grab_pending() activates the inactive item and
subsequently treats it as though it were a standard activated item.

This approach prevents duplicating handling logic for both active and
inactive items, yet the premature activation of an inactive item
triggers trace_workqueue_activate_work(), yielding an unintended user
space visible side effect.

And the unnecessary increment of the nr_active, which is not a simple
counter now, followed by a counteracted decrement, is inefficient and
complicates the code.

Just remove the nr_active manipulation code in grabbing inactive items.

Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c