]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: lpfc: Avoid potential ndlp use-after-free in dev_loss_tmo_callbk
authorJustin Tee <justin.tee@broadcom.com>
Fri, 25 Apr 2025 19:48:03 +0000 (12:48 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 29 Apr 2025 01:38:14 +0000 (21:38 -0400)
commitb5162bb6aa1ec04dff4509b025883524b6d7e7ca
tree117e9d16b2856ca9b30146dfae81bcaa3c1b90d5
parentdf117c93f58ab93c71413496491fdf543dbd7eca
scsi: lpfc: Avoid potential ndlp use-after-free in dev_loss_tmo_callbk

Smatch detected a potential use-after-free of an ndlp oject in
dev_loss_tmo_callbk during driver unload or fatal error handling.

Fix by reordering code to avoid potential use-after-free if initial
nodelist reference has been previously removed.

Fixes: 4281f44ea8bf ("scsi: lpfc: Prevent NDLP reference count underflow in dev_loss_tmo callback")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-scsi/41c1d855-9eb5-416f-ac12-8b61929201a3@stanley.mountain/
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20250425194806.3585-6-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_hbadisc.c