]> www.infradead.org Git - users/dwmw2/linux.git/commit
bpf: Use preempt_count() directly in bpf_send_signal_common()
authorHou Tao <houtao1@huawei.com>
Thu, 20 Feb 2025 04:22:59 +0000 (12:22 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 21 Feb 2025 02:39:38 +0000 (18:39 -0800)
commitb4a8b5bba712a711d8ca1f7d04646db63f9c88f5
tree4154615e889fae2c872e5044e49acccafa3a876e
parentbd4319b6c2b36aa5c6534aec1dbe16921ec960ef
bpf: Use preempt_count() directly in bpf_send_signal_common()

bpf_send_signal_common() uses preemptible() to check whether or not the
current context is preemptible. If it is preemptible, it will use
irq_work to send the signal asynchronously instead of trying to hold a
spin-lock, because spin-lock is sleepable under PREEMPT_RT.

However, preemptible() depends on CONFIG_PREEMPT_COUNT. When
CONFIG_PREEMPT_COUNT is turned off (e.g., CONFIG_PREEMPT_VOLUNTARY=y),
!preemptible() will be evaluated as 1 and bpf_send_signal_common() will
use irq_work unconditionally.

Fix it by unfolding "!preemptible()" and using "preempt_count() != 0 ||
irqs_disabled()" instead.

Fixes: 87c544108b61 ("bpf: Send signals asynchronously if !preemptible")
Signed-off-by: Hou Tao <houtao1@huawei.com>
Link: https://lore.kernel.org/r/20250220042259.1583319-1-houtao@huaweicloud.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/trace/bpf_trace.c