]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath12k: Clear affinity hint before calling ath12k_pci_free_irq() in error path
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Tue, 25 Feb 2025 05:34:46 +0000 (11:04 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Thu, 27 Feb 2025 17:05:28 +0000 (09:05 -0800)
commitb43b1e2c52db77c872bd60d30cdcc72c47df70c7
treeceb7d582fc3966f5a7baa2940e4e3befd5c11bb9
parent68410c5bd381a81bcc92b808e7dc4e6b9ed25d11
wifi: ath12k: Clear affinity hint before calling ath12k_pci_free_irq() in error path

If a shared IRQ is used by the driver due to platform limitation, then the
IRQ affinity hint is set right after the allocation of IRQ vectors in
ath12k_pci_msi_alloc(). This does no harm unless one of the functions
requesting the IRQ fails and attempt to free the IRQ.

This may end up with a warning from the IRQ core that is expecting the
affinity hint to be cleared before freeing the IRQ:

kernel/irq/manage.c:

/* make sure affinity_hint is cleaned up */
if (WARN_ON_ONCE(desc->affinity_hint))
desc->affinity_hint = NULL;

So to fix this issue, clear the IRQ affinity hint before calling
ath12k_pci_free_irq() in the error path. The affinity will be cleared once
again further down the error path due to code organization, but that does
no harm.

Fixes: a3012f206d07 ("wifi: ath12k: set IRQ affinity to CPU0 in case of one MSI vector")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Baochen Qiang <quic_bqiang@quicinc.com>
Link: https://patch.msgid.link/20250225053447.16824-3-manivannan.sadhasivam@linaro.org
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/pci.c