]> www.infradead.org Git - users/willy/pagecache.git/commit
platform/x86: thinkpad_acpi: Fix registration of tpacpi platform driver
authorMark Pearson <mpearson-lenovo@squebb.ca>
Tue, 11 Feb 2025 17:36:11 +0000 (12:36 -0500)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Wed, 12 Feb 2025 11:49:37 +0000 (13:49 +0200)
commitb3e127dacad60a384c92baafdc74f1508bf7dd47
tree4e3c37f023e25fc0622304e61d66fbebe1c32049
parent569617dbbd06286fb73f3f1c2ac91e51d863c7de
platform/x86: thinkpad_acpi: Fix registration of tpacpi platform driver

The recent platform profile changes prevent the tpacpi platform driver
from registering. This error is seen in the kernel logs, and the
various tpacpi entries are not created:

[ 7550.642171] platform thinkpad_acpi: Resources present before probing

This happens because devm_platform_profile_register() is called before
tpacpi_pdev probes (thanks to Kurt Borja for identifying the root
cause).

For now revert back to the old platform_profile_register to fix the
issue. This is quick fix and will be re-implemented later as more
testing is needed for full solution.

Tested on X1 Carbon G12.

Fixes: 31658c916fa6 ("platform/x86: thinkpad_acpi: Use devm_platform_profile_register()")
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
Reviewed-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250211173620.16522-1-mpearson-lenovo@squebb.ca
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/thinkpad_acpi.c