]> www.infradead.org Git - users/jedix/linux-maple.git/commit
power: supply: bq24190: Fix BQ24296 Vbus regulator support
authorHans de Goede <hdegoede@redhat.com>
Sat, 16 Nov 2024 20:36:47 +0000 (21:36 +0100)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 18 Dec 2024 23:35:30 +0000 (00:35 +0100)
commitb3ded6072c5600704cfa3ce3a8dc8718d34bda66
tree97008b36a780b1c5be788ef4fdfb423afdb9984d
parentc28dc9fc24f5fa802d44ef7620a511035bdd803e
power: supply: bq24190: Fix BQ24296 Vbus regulator support

There are 2 issues with bq24296_set_otg_vbus():

1. When writing the OTG_CONFIG bit it uses POC_CHG_CONFIG_SHIFT which
   should be POC_OTG_CONFIG_SHIFT.

2. When turning the regulator off it never turns charging back on. Note
   this must be done through bq24190_charger_set_charge_type(), to ensure
   that the charge_type property value of none/trickle/fast is honored.

Resolve both issues to fix BQ24296 Vbus regulator support not working.

Fixes: b150a703b56f ("power: supply: bq24190_charger: Add support for BQ24296")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20241116203648.169100-2-hdegoede@redhat.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/bq24190_charger.c