]> www.infradead.org Git - users/dwmw2/linux.git/commit
tls: Fix tls_sw_sendmsg error handling
authorBenjamin Coddington <bcodding@redhat.com>
Sat, 4 Jan 2025 15:29:45 +0000 (10:29 -0500)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 Jan 2025 01:00:19 +0000 (17:00 -0800)
commitb341ca51d2679829d26a3f6a4aa9aee9abd94f92
treec75e389676b1bc2856fc996a078a3be5904687a1
parent95978931d55fb7685f8c0b2598d6c12a9b6bc82a
tls: Fix tls_sw_sendmsg error handling

We've noticed that NFS can hang when using RPC over TLS on an unstable
connection, and investigation shows that the RPC layer is stuck in a tight
loop attempting to transmit, but forever getting -EBADMSG back from the
underlying network.  The loop begins when tcp_sendmsg_locked() returns
-EPIPE to tls_tx_records(), but that error is converted to -EBADMSG when
calling the socket's error reporting handler.

Instead of converting errors from tcp_sendmsg_locked(), let's pass them
along in this path.  The RPC layer handles -EPIPE by reconnecting the
transport, which prevents the endless attempts to transmit on a broken
connection.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance")
Link: https://patch.msgid.link/9594185559881679d81f071b181a10eb07cd079f.1736004079.git.bcodding@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tls/tls_sw.c