]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind
authorBjørn Mork <bjorn@mork.no>
Mon, 7 Mar 2016 20:15:36 +0000 (21:15 +0100)
committerChuck Anderson <chuck.anderson@oracle.com>
Tue, 7 Feb 2017 03:52:14 +0000 (19:52 -0800)
commitb338123db53a249c4a14de8cee1870caf7acbc74
tree191860bd4e6ef57fdc416db2b0f3a398dc61d901
parent89c410092c56b48f75a3eb5e319f6a0bb107c963
cdc_ncm: do not call usbnet_link_change from cdc_ncm_bind

usbnet_link_change will call schedule_work and should be
avoided if bind is failing. Otherwise we will end up with
scheduled work referring to a netdev which has gone away.

Instead of making the call conditional, we can just defer
it to usbnet_probe, using the driver_info flag made for
this purpose.

Orabug: 23070825
CVE-2016-3951

Fixes: 8a34b0ae8778 ("usbnet: cdc_ncm: apply usbnet_link_change")
Reported-by: Andrey Konovalov <andreyknvl@gmail.com>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 4d06dd537f95683aba3651098ae288b7cbff8274)
Signed-off-by: Kirtikar Kashyap <kirtikar.kashyap@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
drivers/net/usb/cdc_ncm.c