]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ALSA: control: Avoid WARN() for symlink errors
authorTakashi Iwai <tiwai@suse.de>
Mon, 9 Dec 2024 09:56:12 +0000 (10:56 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 10 Dec 2024 11:32:34 +0000 (12:32 +0100)
commitb2e538a9827dd04ab5273bf4be8eb2edb84357b0
treee46687cf1fbd1822b90e88e952b2336492b0ca80
parentb50a3e98442b8d72f061617c7f7a71f7dba19484
ALSA: control: Avoid WARN() for symlink errors

Using WARN() for showing the error of symlink creations don't give
more information than telling that something goes wrong, since the
usual code path is a lregister callback from each control element
creation.  More badly, the use of WARN() rather confuses fuzzer as if
it were serious issues.

This patch downgrades the warning messages to use the normal dev_err()
instead of WARN().  For making it clearer, add the function name to
the prefix, too.

Fixes: a135dfb5de15 ("ALSA: led control - add sysfs kcontrol LED marking layer")
Reported-by: syzbot+4e7919b09c67ffd198ae@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/675664c7.050a0220.a30f1.018c.GAE@google.com
Link: https://patch.msgid.link/20241209095614.4273-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/control_led.c