]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/bridge: panel: forbid initializing a panel with unknown connector type
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Fri, 14 Feb 2025 12:57:44 +0000 (13:57 +0100)
committerRobert Foss <rfoss@kernel.org>
Mon, 17 Feb 2025 13:17:59 +0000 (14:17 +0100)
commitb296955b3a740ecc8b3b08e34fd64f1ceabb8fb4
tree43ab5955e08debdc898545f6086a4c5ea91786c9
parent77053ef7207a964c3b8e4e38dda2e273da5ccfb3
drm/bridge: panel: forbid initializing a panel with unknown connector type

Having an DRM_MODE_CONNECTOR_Unknown connector type is considered bad, and
drm_panel_bridge_add_typed() and derivatives are deprecated for this.

drm_panel_init() won't prevent initializing a panel with a
DRM_MODE_CONNECTOR_Unknown connector type. Luckily there are no in-tree
users doing it, so take this as an opportinuty to document a valid
connector type must be passed.

Returning an error if this rule is violated is not possible because
drm_panel_init() is a void function. Add at least a warning to make any
violations noticeable, especially to non-upstream drivers.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250214-drm-assorted-cleanups-v7-5-88ca5827d7af@bootlin.com
drivers/gpu/drm/drm_panel.c