]> www.infradead.org Git - users/jedix/linux-maple.git/commit
lib: string_helpers: fix potential snprintf() output truncation
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 21 Oct 2024 09:14:17 +0000 (11:14 +0200)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 1 Nov 2024 04:28:04 +0000 (21:28 -0700)
commitb15272e82d70eb814ec628bde17ebb232408d247
treeae078557b1d083e1910323fab60eed3fb4a229d0
parent4e2c5e63344a0768bab73f5e8e449a0c549112a4
lib: string_helpers: fix potential snprintf() output truncation

The output of ".%03u" with the unsigned int in range [0, 4294966295] may
get truncated if the target buffer is not 12 bytes.

Link: https://lkml.kernel.org/r/20241021091417.37796-1-brgl@bgdev.pl
Fixes: 3c9f3681d0b4 ("[SCSI] lib: add generic helper to print sizes rounded to the correct SI range")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Cc: James E.J. Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Kees Cook <kees@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/string_helpers.c