]> www.infradead.org Git - users/jedix/linux-maple.git/commit
phonet: fix building with clang
authorArnd Bergmann <arnd@arndb.de>
Tue, 19 Feb 2019 21:53:50 +0000 (22:53 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 13:35:16 +0000 (14:35 +0100)
commitb0f38ebe0504d2f89281ee3c1d01eb1459b65db4
tree19b115537463e262d0dccc4669e626cb331194de
parent760884bcd3427a17a4b464c02a3d90f0043a9f9c
phonet: fix building with clang

[ Upstream commit 6321aa197547da397753757bd84c6ce64b3e3d89 ]

clang warns about overflowing the data[] member in the struct pnpipehdr:

net/phonet/pep.c:295:8: warning: array index 4 is past the end of the array (which contains 1 element) [-Warray-bounds]
                        if (hdr->data[4] == PEP_IND_READY)
                            ^         ~
include/net/phonet/pep.h:66:3: note: array 'data' declared here
                u8              data[1];

Using a flexible array member at the end of the struct avoids the
warning, but since we cannot have a flexible array member inside
of the union, each index now has to be moved back by one, which
makes it a little uglier.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Rémi Denis-Courmont <remi@remlab.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/net/phonet/pep.h
net/phonet/pep.c