]> www.infradead.org Git - users/jedix/linux-maple.git/commit
staging: gpib: Move free after the variable use has been completed
authorEverest K.C. <everestkc@everestkc.com.np>
Tue, 15 Oct 2024 21:51:55 +0000 (15:51 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Oct 2024 07:55:31 +0000 (09:55 +0200)
commitb0a7dfeb7df670bb8603e043c9634aa9eda42a49
treeaea34fbd26fc1fa1ac5dee40d0b5ed05321250fe
parentafa0ab042efe968c0f234239cbaeede6f5779c86
staging: gpib: Move free after the variable use has been completed

The variable `in_data` is freed, but used later in the code.
Fix it by moving the freeing the memory after it use has been
completed.

This issue was reported by Coverity Scan.
Report:
CID 1600783: (#1 of 1): Use after free (USE_AFTER_FREE)
19. pass_freed_arg: Passing freed pointer in_data as an argument to
ni_usb_dump_raw_block.

Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driver")
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20241015215157.18571-1-everestkc@everestkc.com.np
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/ni_usb/ni_usb_gpib.c