]> www.infradead.org Git - users/hch/misc.git/commit
HID: hid-steam: Don't use cancel_delayed_work_sync in IRQ context
authorVicki Pfau <vi@endrift.com>
Wed, 5 Feb 2025 03:55:29 +0000 (19:55 -0800)
committerJiri Kosina <jkosina@suse.com>
Fri, 7 Feb 2025 13:27:48 +0000 (14:27 +0100)
commitb051ffa2aeb2a60e092387b6fb2af1ad42f51a3c
tree620e39e850dc31419dad764e3ad9d1ff5db1de43
parent79504249d7e27cad4a3eeb9afc6386e418728ce0
HID: hid-steam: Don't use cancel_delayed_work_sync in IRQ context

Lockdep reported that, as steam_do_deck_input_event is called from
steam_raw_event inside of an IRQ context, it can lead to issues if that IRQ
occurs while the work to be cancelled is running. By using cancel_delayed_work,
this issue can be avoided. The exact ordering of the work and the event
processing is not super important, so this is safe.

Fixes: cd438e57dd05 ("HID: hid-steam: Add gamepad-only mode switched to by holding options")
Signed-off-by: Vicki Pfau <vi@endrift.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/hid-steam.c