]> www.infradead.org Git - users/willy/pagecache.git/commit
ice: disallow DPLL_PIN_STATE_SELECTABLE for dpll output pins
authorArkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Thu, 12 Sep 2024 08:54:28 +0000 (10:54 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 30 Sep 2024 21:23:32 +0000 (14:23 -0700)
commitafe6e30e7701979f536f8fbf6fdef7212441f61a
tree31494f1af494bab424d0aa1c77496974c725de30
parentc188afdc36113760873ec78cbc036f6b05f77621
ice: disallow DPLL_PIN_STATE_SELECTABLE for dpll output pins

Currently the user may request DPLL_PIN_STATE_SELECTABLE for an output
pin, and this would actually set the DISCONNECTED state instead.

It doesn't make any sense. SELECTABLE is valid only in case of input pins
(on AUTOMATIC type dpll), where dpll itself would select best valid input.
For the output pin only CONNECTED/DISCONNECTED are expected.

Fixes: d7999f5ea64b ("ice: implement dpll interface to control cgu")
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_dpll.c