]> www.infradead.org Git - users/jedix/linux-maple.git/commit
lib: 842: Improve error handling in sw842_compress()
authorTanya Agarwal <tanyaagarwal25699@gmail.com>
Tue, 14 Jan 2025 14:12:04 +0000 (19:42 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sun, 9 Feb 2025 10:08:11 +0000 (18:08 +0800)
commitaf324dc0e2b558678aec42260cce38be16cc77ca
treed73cd513fc59eb71948c780c0908fb4ef2fcfa17
parent9739f5f93b7806a684713ba42e6ed2d1df7c8100
lib: 842: Improve error handling in sw842_compress()

The static code analysis tool "Coverity Scan" pointed the following
implementation details out for further development considerations:
CID 1309755: Unused value
In sw842_compress: A value assigned to a variable is never used. (CWE-563)
returned_value: Assigning value from add_repeat_template(p, repeat_count)
to ret here, but that stored value is overwritten before it can be used.

Conclusion:
Add error handling for the return value from an add_repeat_template()
call.

Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")
Signed-off-by: Tanya Agarwal <tanyaagarwal25699@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
lib/842/842_compress.c