]> www.infradead.org Git - users/jedix/linux-maple.git/commit
phy: freescale: imx8m-pcie: assert phy reset and perst in power off
authorStefan Eichenberger <stefan.eichenberger@toradex.com>
Wed, 5 Mar 2025 14:43:16 +0000 (15:43 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 10 Mar 2025 19:42:37 +0000 (01:12 +0530)
commitaecb63e88c5e5fb9afb782a1577264c76f179af9
treed460cbf67017b4bf3227c26c97139206357c9336
parent97e8a2ff28a3dc36ca3cdc94f37359852d7e1c8b
phy: freescale: imx8m-pcie: assert phy reset and perst in power off

Ensure the PHY reset and perst is asserted during power-off to
guarantee it is in a reset state upon repeated power-on calls. This
resolves an issue where the PHY may not properly initialize during
subsequent power-on cycles. Power-on will deassert the reset at the
appropriate time after tuning the PHY parameters.

During suspend/resume cycles, we observed that the PHY PLL failed to
lock during resume when the CPU temperature increased from 65C to 75C.
The observed errors were:
  phy phy-32f00000.pcie-phy.3: phy poweron failed --> -110
  imx6q-pcie 33800000.pcie: waiting for PHY ready timeout!
  imx6q-pcie 33800000.pcie: PM: dpm_run_callback(): genpd_resume_noirq+0x0/0x80 returns -110
  imx6q-pcie 33800000.pcie: PM: failed to resume noirq: error -110

This resulted in a complete CPU freeze, which is resolved by ensuring
the PHY is in reset during power-on, thus preventing PHY PLL failures.

Cc: stable@vger.kernel.org
Fixes: 1aa97b002258 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250305144355.20364-3-eichest@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/freescale/phy-fsl-imx8m-pcie.c