]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/msm/dp: fix runtime_pm handling in dp_wait_hpd_asserted
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 26 Feb 2024 22:34:45 +0000 (00:34 +0200)
committerRob Clark <robdclark@chromium.org>
Wed, 5 Jun 2024 22:53:29 +0000 (15:53 -0700)
commitaeacc39e2088a15ee31c8af4f68c84981fa08eb7
treedb4ec56cb7692af8961d4286310f74c5ae934a3a
parent6ed817592638348e83facfe6a4deedb8d5e83357
drm/msm/dp: fix runtime_pm handling in dp_wait_hpd_asserted

The function dp_wait_hpd_asserted() uses pm_runtime_get_sync() and
doesn't care about the return value. Potentially this can lead to
unclocked access if for some reason resuming of the DP controller fails.

Change the function to use pm_runtime_resume_and_get() and return an
error if resume fails.

Fixes: e2969ee30252 ("drm/msm/dp: move of_dp_aux_populate_bus() to eDP probe()")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/580137/
Link: https://lore.kernel.org/r/20240226223446.4194079-1-dmitry.baryshkov@linaro.org
[quic_abhinavk@quicinc.com: resolved trivial conflict while rebase]
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/dp/dp_aux.c