]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ASoC: sun4i-codec: correct dapm widgets and controls for h616
authorRyan Walklin <ryan@testtoast.com>
Fri, 14 Feb 2025 22:02:24 +0000 (11:02 +1300)
committerMark Brown <broonie@kernel.org>
Thu, 13 Mar 2025 22:50:05 +0000 (22:50 +0000)
commitae5f76d4044d1580849316c49290678605e0889d
treeae6445acd36858f7107678c50809aaba90e677db
parent7bda89a2489fb012c4c63f3338827ad1f35c8880
ASoC: sun4i-codec: correct dapm widgets and controls for h616

The previous H616 support patch added a single LINEOUT DAPM pin switch
to the card controls. As the codec in this SoC only has a single route,
this seemed reasonable at the time, however is redundant given the
existing DAPM codec widget definitions controlling the digital and
analog sides of the codec.

It is also insufficient to describe the scenario where separate
components (muxes, jack detection etc) are used to modify the audio
route external to the SoC. For example the Anbernic RG(##)XX series of
devices uses a headphone jack detection switch, GPIO-controlled speaker
amplifier and a passive external mux chip to route audio.

Remove the redundant LINEOUT card control, and add a Speaker pin switch
control and Headphone DAPM widget to allow control of the above
hardware.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Ryan Walklin <ryan@testtoast.com>
Tested-by: Philippe Simons <simons.philippe@gmail.com>
Link: https://patch.msgid.link/20250214220247.10810-3-ryan@testtoast.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sunxi/sun4i-codec.c