]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pinctrl: core: fix possible memory leak when pinctrl_enable() fails
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 6 Jun 2024 02:37:02 +0000 (10:37 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Jun 2024 08:33:30 +0000 (10:33 +0200)
commitae1cf4759972c5fe665ee4c5e0c29de66fe3cf4a
tree584ea3ab8a4eddf7bdfda31b4d2b4a0bbdebb70b
parent1583dc1627f6f9a24f570eec53fa20f1b4a5758f
pinctrl: core: fix possible memory leak when pinctrl_enable() fails

In devm_pinctrl_register(), if pinctrl_enable() fails in pinctrl_register(),
the "pctldev" has not been added to dev resources, so devm_pinctrl_dev_release()
can not be called, it leads memory leak.

Introduce pinctrl_uninit_controller(), call it in the error path to free memory.

Fixes: 5038a66dad01 ("pinctrl: core: delete incorrect free in pinctrl_enable()")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240606023704.3931561-2-yangyingliang@huawei.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/core.c