]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dmaengine: avoid non-constant format string
authorArnd Bergmann <arnd@arndb.de>
Fri, 19 Jul 2024 10:23:12 +0000 (12:23 +0200)
committerVinod Koul <vkoul@kernel.org>
Thu, 29 Aug 2024 17:19:53 +0000 (22:49 +0530)
commitae04342b5264fcf90a288a984a69ffb9e93904a7
tree90c1bbdf3e53ded6ddaaa2cb4673b27a01488dad
parent39dc2a4929f7be748b37a5070f41afe7bcb60706
dmaengine: avoid non-constant format string

Using an arbitrary string as a printf-style format can be a security
problem if that string contains % characters, as the optionalal
-Wformat-security flag points out:

drivers/dma/dmaengine.c: In function '__dma_async_device_channel_register':
drivers/dma/dmaengine.c:1073:17: error: format not a string literal and no format arguments [-Werror=format-security]
 1073 |                 dev_set_name(&chan->dev->device, name);
      |                 ^~~~~~~~~~~~

Change this newly added instance to use "%s" as the format instead to
pass the actual name.

Fixes: 10b8e0fd3f72 ("dmaengine: add channel device name to channel registration")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20240719102319.546622-1-arnd@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dmaengine.c