]> www.infradead.org Git - users/jedix/linux-maple.git/commit
igc: remove autoneg parameter from igc_mac_info
authorVitaly Lifshits <vitaly.lifshits@intel.com>
Tue, 1 Oct 2024 17:05:31 +0000 (20:05 +0300)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 13 Nov 2024 18:30:21 +0000 (10:30 -0800)
commitade6fded7957fd10a152de98513e4af3ff76ab71
tree779262727c44ce6c3d4fafa09218390eb6aca2b1
parent4b2c75ffeaadfce0ffdd97fbd0bbcad5c4f83131
igc: remove autoneg parameter from igc_mac_info

Since the igc driver doesn't support forced speed configuration and
its current related hardware doesn't support it either, there is no
use of the mac.autoneg parameter. Moreover, in one case this usage
might result in a NULL pointer dereference due to an uninitialized
function pointer, phy.ops.force_speed_duplex.

Therefore, remove this parameter from the igc code.

Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc_diag.c
drivers/net/ethernet/intel/igc/igc_ethtool.c
drivers/net/ethernet/intel/igc/igc_hw.h
drivers/net/ethernet/intel/igc/igc_mac.c
drivers/net/ethernet/intel/igc/igc_main.c
drivers/net/ethernet/intel/igc/igc_phy.c