]> www.infradead.org Git - users/jedix/linux-maple.git/commit
eth: bnxt: add missing netdev lock management to bnxt_dl_reload_up
authorStanislav Fomichev <sdf@fomichev.me>
Sun, 9 Mar 2025 21:58:51 +0000 (14:58 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 12 Mar 2025 20:19:15 +0000 (13:19 -0700)
commitadbf627f170382684f095c261866510b2b70d841
tree4d9654bb37f61c1e1419bb76c1cf6552a7610bf5
parenteaca6e5dc6ba19422989e73415a49042b2062ed0
eth: bnxt: add missing netdev lock management to bnxt_dl_reload_up

bnxt_dl_reload_up is completely missing instance lock management
which can result in `devlink dev reload` leaving with instance
lock held. Add the missing calls.

Also add netdev_assert_locked to make it clear that the up() method
is running with the instance lock grabbed.

v2:
- add net/netdev_lock.h include to bnxt_devlink.c for netdev_assert_locked

Fixes: 004b5008016a ("eth: bnxt: remove most dependencies on RTNL")
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250309215851.2003708-3-sdf@fomichev.me
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c