]> www.infradead.org Git - users/hch/xfs.git/commit
ice: remove af_xdp_zc_qps bitmap
authorLarysa Zaremba <larysa.zaremba@intel.com>
Mon, 3 Jun 2024 21:42:32 +0000 (14:42 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 6 Jun 2024 02:27:56 +0000 (19:27 -0700)
commitadbf5a42341f6ea038d3626cd4437d9f0ad0b2dd
treea4c9f031f73686f03f3d3635588caca1334b4f42
parentcfa747a66e5da34793ac08c26b814e7709613fab
ice: remove af_xdp_zc_qps bitmap

Referenced commit has introduced a bitmap to distinguish between ZC and
copy-mode AF_XDP queues, because xsk_get_pool_from_qid() does not do this
for us.

The bitmap would be especially useful when restoring previous state after
rebuild, if only it was not reallocated in the process. This leads to e.g.
xdpsock dying after changing number of queues.

Instead of preserving the bitmap during the rebuild, remove it completely
and distinguish between ZC and copy-mode queues based on the presence of
a device associated with the pool.

Fixes: e102db780e1c ("ice: track AF_XDP ZC enabled queues in bitmap")
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20240603-net-2024-05-30-intel-net-fixes-v2-3-e3563aa89b0c@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice.h
drivers/net/ethernet/intel/ice/ice_lib.c
drivers/net/ethernet/intel/ice/ice_xsk.c