]> www.infradead.org Git - users/jedix/linux-maple.git/commit
RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv
authorSowmini Varadhan <sowmini.varadhan@oracle.com>
Mon, 26 Oct 2015 16:46:37 +0000 (12:46 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Fri, 5 Feb 2016 03:28:34 +0000 (19:28 -0800)
commitad8128625a295bf73fd2eea25cf673e09742a0d7
tree38b5a28a84630e71c0702ad9bcac3bda91fefe1e
parent80a99bb7f0185f6b5fce6b22a93a7701ffe0a25b
RDS-TCP: Recover correctly from pskb_pull()/pksb_trim() failure in rds_tcp_data_recv

Orabug: 22623837

[ Upstream commit 8ce675ff39b9958d1c10f86cf58e357efaafc856 ]

Either of pskb_pull() or pskb_trim() may fail under low memory conditions.
If rds_tcp_data_recv() ignores such failures, the application will
receive corrupted data because the skb has not been correctly
carved to the RDS datagram size.

Avoid this by handling pskb_pull/pskb_trim failure in the same
manner as the skb_clone failure: bail out of rds_tcp_data_recv(), and
retry via the deferred call to rds_send_worker() that gets set up on
ENOMEM from rds_tcp_read_sock()

Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 7d5b34f8f87376c530b006195e398a58364451af)
Signed-off-by: Dan Duval <dan.duval@oracle.com>
net/rds/tcp_recv.c