]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf tools: Avoid unaligned pointer operations
authorNamhyung Kim <namhyung@kernel.org>
Thu, 28 Nov 2024 01:03:25 +0000 (17:03 -0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 12 Dec 2024 18:36:46 +0000 (15:36 -0300)
commitad5d76aecdcfe73a4093a9755a991f172d2d2492
tree07337b263e7a27a0879f9705d797696750b30a0b
parentb1ef2559d5579b1bc34f062aef53e9c1e52c91b0
perf tools: Avoid unaligned pointer operations

The sample data is 64-bit aligned basically but raw data starts with
32-bit length field and data follows.  In perf_event__synthesize_sample
it treats the sample data as a 64-bit array.  And it needs some trick
to update the raw data properly.

But it seems some compilers are not happy with this and the program dies
siliently.  I found the sample parsing test failed without any messages
on affected systems.

Let's update the code to use a 32-bit pointer directly and make sure the
result is 64-bit aligned again.  No functional changes intended.

Reviewed-by: Ian Rogers <irogers@google.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20241128010325.946897-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/synthetic-events.c