]> www.infradead.org Git - users/jedix/linux-maple.git/commit
locking/atomic, xen: Use sync_try_cmpxchg() instead of sync_cmpxchg()
authorUros Bizjak <ubizjak@gmail.com>
Mon, 10 Jul 2023 19:01:27 +0000 (21:01 +0200)
committerIngo Molnar <mingo@kernel.org>
Mon, 9 Oct 2023 16:14:34 +0000 (18:14 +0200)
commitad0a2e4c2f20510d7e3f2bc110cf74f8578547f0
tree0f5fe98b87c809da5a0fcf44691ece720caf5ab1
parent636d6a8b850a2bb8462b5f743c9db9aa4d735cda
locking/atomic, xen: Use sync_try_cmpxchg() instead of sync_cmpxchg()

Use sync_try_cmpxchg() instead of sync_cmpxchg(*ptr, old, new) == old
in clear_masked_cond(), clear_linked() and
gnttab_end_foreign_access_ref_v1(). x86 CMPXCHG instruction returns
success in ZF flag, so this change saves a compare after cmpxchg
(and related move instruction in front of cmpxchg), improving the
cmpxchg loop in gnttab_end_foreign_access_ref_v1() from:

     174: eb 0e                 jmp    184 <...>
     176: 89 d0                 mov    %edx,%eax
     178: f0 66 0f b1 31        lock cmpxchg %si,(%rcx)
     17d: 66 39 c2              cmp    %ax,%dx
     180: 74 11                 je     193 <...>
     182: 89 c2                 mov    %eax,%edx
     184: 89 d6                 mov    %edx,%esi
     186: 66 83 e6 18           and    $0x18,%si
     18a: 74 ea                 je     176 <...>

to:

     614: 89 c1                 mov    %eax,%ecx
     616: 66 83 e1 18           and    $0x18,%cx
     61a: 75 11                 jne    62d <...>
     61c: f0 66 0f b1 0a        lock cmpxchg %cx,(%rdx)
     621: 75 f1                 jne    614 <...>

No functional change intended.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Juergen Gross <jgross@suse.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
drivers/xen/events/events_fifo.c
drivers/xen/grant-table.c