]> www.infradead.org Git - users/dwmw2/linux.git/commit
xfs: take XFS_MMAPLOCK_EXCL xfs_file_write_zero_eof
authorChristoph Hellwig <hch@lst.de>
Tue, 8 Oct 2024 08:59:16 +0000 (10:59 +0200)
committerCarlos Maiolino <cem@kernel.org>
Tue, 15 Oct 2024 09:37:42 +0000 (11:37 +0200)
commitacfbac776496f2093e9facf7876b4015ef8c3d1d
tree888998290e587ee64f043b440bccb304d95aa352
parent3c399374af28b158854701da324a7bff576f5a97
xfs: take XFS_MMAPLOCK_EXCL xfs_file_write_zero_eof

xfs_file_write_zero_eof is the only caller of xfs_zero_range that does
not take XFS_MMAPLOCK_EXCL (aka the invalidate lock).  Currently that
is actually the right thing, as an error in the iomap zeroing code will
also take the invalidate_lock to clean up, but to fix that deadlock we
need a consistent locking pattern first.

The only extra thing that XFS_MMAPLOCK_EXCL will lock out are read
pagefaults, which isn't really needed here, but also not actively
harmful.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_file.c
fs/xfs/xfs_iomap.c